Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix an error on README #399

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 8, 2020

Summary

This pull request just fixes a minor error in a code example on README.

Requirements (place an x in each [ ])

@seratch seratch added the docs M-T: Documentation work only label Feb 8, 2020
@seratch seratch self-assigned this Feb 8, 2020
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #399 into @slack/bolt@next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #399   +/-   ##
=================================================
  Coverage             85.37%   85.37%           
=================================================
  Files                     7        7           
  Lines                   506      506           
  Branches                144      144           
=================================================
  Hits                    432      432           
  Misses                   49       49           
  Partials                 25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ca14a...332db76. Read the comment docs.

@seratch seratch added this to the V2 milestone Feb 13, 2020
@seratch
Copy link
Member Author

seratch commented Feb 13, 2020

I will merge this PR after merging barlock's PRs.

@seratch
Copy link
Member Author

seratch commented Feb 18, 2020

It seems merging this PR doesn't mean requiring barlock to rebase his PRs. This one obviously doesn't have any conflicts. Let me merge this now.

@seratch seratch merged commit 3400479 into slackapi:@slack/bolt@next Feb 18, 2020
@seratch seratch deleted the readme-fix-next branch February 18, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant